fix: add correct constraints for pre-release versions#5348
Merged
Conversation
lpil
reviewed
Feb 1, 2026
lpil
left a comment
lpil
left a comment
Member
There was a problem hiding this comment.
Hello! Thank you!
Could we also extract the range generation to a function and write some tests for that please 🙏
Signed-off-by: Andrey <andrekabatareika@gmail.com>
Signed-off-by: Andrey <andrekabatareika@gmail.com>
ankddev
force-pushed
the
rc-constraints
branch
from
February 19, 2026 12:16
ae94c00 to
c9bcb53
Compare
Contributor
Author
|
@lpil I think that it's done now. I've created a new function in |
giacomocavalieri
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4220. It's very simple fix, I've just replaced manual version construction with
Displayimplementation forVersion.