Switch from Cap'n'proto to Serde for cache#5358
Merged
Merged
Conversation
lpil
reviewed
Feb 25, 2026
lpil
marked this pull request as draft
February 25, 2026 18:25
GearsDatapacks
force-pushed
the
capnp-to-serde
branch
from
February 25, 2026 20:04
c18cfe9 to
406a83b
Compare
GearsDatapacks
marked this pull request as ready for review
February 25, 2026 21:36
GearsDatapacks
force-pushed
the
capnp-to-serde
branch
2 times, most recently
from
March 9, 2026 16:37
5445a5d to
1893fdd
Compare
GearsDatapacks
force-pushed
the
capnp-to-serde
branch
from
March 17, 2026 09:20
1893fdd to
788d3d0
Compare
GearsDatapacks
force-pushed
the
capnp-to-serde
branch
from
March 17, 2026 13:32
788d3d0 to
aaf8ef8
Compare
Contributor
|
@lpil Just wondering if it's good to use bincode here, since it's unmantained. Some projects are migrating to alternatives and some ones are staying on it unless there are some problems with it, so maybe it's good enough for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1599 and fixes #5260
This PR replaces Cap'n'proto with Serde and Bincode for module caching. I have also merged the
cache_inlineandcache_modulefiles into the main.cacheas I don't see a reason for them to be kept separate anymore.