Delete compile file after compilation#5375
Open
ankddev wants to merge 9 commits intogleam-lang:mainfrom
Open
Conversation
lpil
reviewed
Feb 25, 2026
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Thank you! Few tiny things inline
Forgot to commit it
ankddev
force-pushed
the
delete-compile-file-after-compilation
branch
from
548cbfd to
1171d53
Compare
ankddev
commented
Feb 26, 2026
Comment on lines
+136
to
+139
| pub fn compilation_escript_path(out: &Utf8Path) -> Utf8PathBuf { | ||
| out.join(ARTEFACT_DIRECTORY_NAME).join("gleam@@compile.erl") | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@lpil I've moved this function to paths module. I've thought about placing it under ProjectPaths, but BeamCompiler and its callers don't receive ProjectPaths, they receive just out, so this would require some refactoring. What are your thoughts?
Contributor
Author
|
Oh, it seems that I forgot to add a changelog entry, will do it! |
Contributor
Author
|
It's done now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4474. I hope that it's right place to place, but I'm not sure, since why error while deleting file should fail the entire run?