Warn when Erlang shipment is run on a different OTP version#5420
Open
nootr wants to merge 1 commit intogleam-lang:mainfrom
Open
Warn when Erlang shipment is run on a different OTP version#5420nootr wants to merge 1 commit intogleam-lang:mainfrom
nootr wants to merge 1 commit intogleam-lang:mainfrom
Conversation
Detect the OTP version at build time and embed a check into the entrypoint scripts. If the running OTP version differs, a warning is printed to stderr before the program runs. Closes gleam-lang#4769
nootr
force-pushed
the
otp-version-warning-erlang-shipment
branch
from
76a8ad6 to
bc984e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an Erlang shipment is built with one OTP version and run with a different one, the program crashes with a cryptic
undeferror. This commit embeds a version check into the generated entrypoint scripts that prints a clear warning to stderr when a mismatch is detected, without booting the Erlang VM twice.Closes #4769
Test plan
cargo check/cargo clippy/cargo fmtpasscargo test -p gleam-core -p gleam-clipasses