show some completions for record updates#5439
Open
giacomocavalieri wants to merge 1 commit intogleam-lang:mainfrom
Open
show some completions for record updates#5439giacomocavalieri wants to merge 1 commit intogleam-lang:mainfrom
giacomocavalieri wants to merge 1 commit intogleam-lang:mainfrom
Conversation
giacomocavalieri
force-pushed
the
fix-5435
branch
2 times, most recently
from
9505dc4 to
3388fa5
Compare
giacomocavalieri
force-pushed
the
fix-5435
branch
from
3388fa5 to
adc79e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds label completions for record updates, just like function calls. This works when the code goes from a compiling state, eg. I'm typing
Wibble(..todo, |), to an invalid state with a syntax error,Wibble(..todo, w|)because it relies on an outdated view of the LS of the project which happens to be good enough to provide completions.I can't think of a good way of testing this, I'd like to hear what you think we could do for tests.