Support textDocument/documentHighlight for usages of values#5452
Draft
gavinmorrow wants to merge 3 commits intogleam-lang:mainfrom
Draft
Support textDocument/documentHighlight for usages of values#5452gavinmorrow wants to merge 3 commits intogleam-lang:mainfrom
textDocument/documentHighlight for usages of values#5452gavinmorrow wants to merge 3 commits intogleam-lang:mainfrom
Conversation
gavinmorrow
changed the title
textDocument/documentHighlight for usages of values
gavinmorrow
force-pushed
the
gavinmorrow/document-highlight-values
branch
from
000343b to
eca9199
Compare
gavinmorrow
force-pushed
the
gavinmorrow/document-highlight-values
branch
from
eca9199 to
43f0a6f
Compare
Contributor
Author
|
This feature uses the code for find references under the hood, because it is essentially a "find references in this file/module". I'm not really sure what to do about testing. Should the references.rs file be copied and renamed to document_highlights.rs and the tests very slightly changed? (For the most part a s/references/highlights.) Or should the tests be bundled in with the ones for references? Or something else entirely? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5441.