Fix byteOffset typo in BitArray DataView construction#5465
Open
jtdowney wants to merge 1 commit intogleam-lang:mainfrom
Open
Fix byteOffset typo in BitArray DataView construction#5465jtdowney wants to merge 1 commit intogleam-lang:mainfrom
jtdowney wants to merge 1 commit intogleam-lang:mainfrom
Conversation
BitArray$BitArray$data used `array.byteOffest` (swpped 'e'), which evaluated to undefined and caused DataView to always read from offset 0 instead of the slice's actual start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went to try out the new
BitArray$BitArray$dataJS FFI function and ran into an issue. There's a typo that results inundefined, which is then treated as a zero offset. So if you're using a bit array with an offset, the offset will be ignored, and the read will start at the beginning of the array.