change Erlang code generation#5905
Merged
lpil merged 19 commits intoJul 14, 2026
Merged
Conversation
lpil
reviewed
Jun 26, 2026
giacomocavalieri
force-pushed
the
compile-to-abstract-forms
branch
4 times, most recently
from
July 1, 2026 20:56
efc2ec6 to
0184250
Compare
giacomocavalieri
force-pushed
the
compile-to-abstract-forms
branch
2 times, most recently
from
July 8, 2026 09:50
ee788e5 to
0bb4a29
Compare
giacomocavalieri
force-pushed
the
compile-to-abstract-forms
branch
from
July 10, 2026 06:43
0bb4a29 to
0311d6b
Compare
giacomocavalieri
force-pushed
the
compile-to-abstract-forms
branch
2 times, most recently
from
July 10, 2026 10:35
52c6ba8 to
0472e89
Compare
giacomocavalieri
force-pushed
the
compile-to-abstract-forms
branch
from
July 10, 2026 13:49
0472e89 to
5bc5d6c
Compare
giacomocavalieri
force-pushed
the
compile-to-abstract-forms
branch
from
July 10, 2026 14:57
5bc5d6c to
ae83877
Compare
lpil
reviewed
Jul 10, 2026
giacomocavalieri
marked this pull request as ready for review
July 10, 2026 15:18
lpil
reviewed
Jul 11, 2026
lpil
reviewed
Jul 11, 2026
lpil
force-pushed
the
compile-to-abstract-forms
branch
2 times, most recently
from
July 12, 2026 10:19
0bcad29 to
a5e6cd4
Compare
lpil
force-pushed
the
compile-to-abstract-forms
branch
from
July 12, 2026 11:15
a5e6cd4 to
b4547e2
Compare
lpil
force-pushed
the
compile-to-abstract-forms
branch
from
July 14, 2026 10:59
4aa11eb to
2e6b805
Compare
lpil
force-pushed
the
compile-to-abstract-forms
branch
from
July 14, 2026 11:24
275fe1e to
6e65e2c
Compare
lpil
approved these changes
Jul 14, 2026
lpil
left a comment
Member
There was a problem hiding this comment.
Jak this rules!!!
also wow I've never had a worse time with github's UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we're switching the Erlang code generation to the current pretty printing approach to a new code generator that is better suited to later be used to produce the binary Erlang Abstract Format!
prettymodule!let assertwith an aliased string prefix pattern generates invalid Erlang #5935 too, changing how let assert expression are compilednowarn_ignoredcompilation flag