Add code action to rewrite numbers in a different base#5965
Merged
Conversation
giacomocavalieri
changed the title
0xda157
reviewed
Jul 13, 2026
giacomocavalieri
force-pushed
the
fix-5889
branch
from
July 14, 2026 12:01
eb23d11 to
48c4bc7
Compare
Member
|
dbgs left in! |
giacomocavalieri
force-pushed
the
fix-5889
branch
from
July 14, 2026 13:11
e20496f to
f7f1eff
Compare
Member
Author
|
Oops, fixed! |
lpil
reviewed
Jul 14, 2026
lpil
left a comment
lpil
left a comment
Member
There was a problem hiding this comment.
Thank you!! One tiny question inline
giacomocavalieri
force-pushed
the
fix-5889
branch
from
July 14, 2026 14:44
f7f1eff to
c154b8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #5889
It also fixes a bug in the lexer to accept
-0x...,-0b...,-0o...as proper negative numbers.