Fix unused module name warning#5982
Open
jtdowney wants to merge 2 commits into
Open
Conversation
lpil
reviewed
Jul 17, 2026
lpil
left a comment
Member
There was a problem hiding this comment.
Fab, thank you! One tiny note inline
jtdowney
force-pushed
the
fix-unused-module-name
branch
from
July 17, 2026 14:02
df376c8 to
c46a638
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an incorrect unused imported module warning when one imports local name matches another imports full module name.
For example
Both imports are used, but the compiler reported
wibble/wobbleas unused.The type checker resolved
wobble.hello()towibble/wobblecorrectly. The reference tracker then recorded the use by looking up the stringwobbleagain.That lookup accepted two different kinds of names:
wobbleormy_wobblewibble/wobbleorwobbleBecause the second import's full name was
wobble, the reference tracker attached the use to the wrong import. Type checking and generated code were correct. Only the usage graph and the warning were wrong.I also noticed and fixed a similar but different bug related to an import with a discard alias.
Closes #5975