Replace most external test APIs with local mock server#57
Open
jtdowney wants to merge 1 commit intogleam-lang:mainfrom
Open
Replace most external test APIs with local mock server#57jtdowney wants to merge 1 commit intogleam-lang:mainfrom
jtdowney wants to merge 1 commit intogleam-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a mock HTTP server that operates similarly to https://httpbin.org. There are two places where it still uses the old tests, but there is a line of sight to moving those over as well.
invalid_tls_testexpects a "typical" TLS error like an expired certificate. I felt like it would change the spirit of the test to have it test against an unknown CA. This can move to a local test PKI once Add custom cacert support #36 is finished.ipv6_testcould be replaced with a request tohttp://[::1]:8080once IPv6 addresses with brackets are not handled correctly. #34 is finished.With a local test PKI, additional testing could be added for #55 as well.
Closes #56