Fix actor init timeout sending exit message to linked parent

[sbergen]

Resolves #73

In addition to returning an error, a timed out actor init would also propagate the exit message to the parent process, causing it to get killed unless it was trapping exits.

[lpil]

Reading the source for proc_lib I can't see anything that suggests that the process should unlink. And wouldn't doing this result in supervisors not working?

Perhaps the problem here is how it is communicated. Or is there a more suited API?

[sbergen]

Reading the source for proc_lib I can't see anything that suggests that the process should unlink. And wouldn't doing this result in supervisors not working?

The unlinking happens here, called if a timeout occurs.

Perhaps the problem here is how it is communicated. Or is there a more suited API?

The problem is that if we don't unlink, actor.InitTimeout is pretty pointless, as it can't normally be handled by the caller. If I see a Result being returned, I don't expect to crash unless I trap exits.

InitCrashed is also a bit problematic for this reason, but in Erlang, as far as I understood (I've never actually written any Erlang), for that one you would need to trap exits, so perhaps it could be fixed with clearer documentation?

If function start_link/3,4,5 is used and the process crashes before it has called init_ack/1,2, {error, Reason} is returned if the calling process traps exits.

[lpil]

Wonderful, thank you. I totally missed that while reading the Erlang there. Great work!