Skip to content

Upgrade dynamic module #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

Upgrade dynamic module #829

merged 5 commits into from
May 13, 2025

Conversation

lpil
Copy link
Member

@lpil lpil commented May 9, 2025

No description provided.

@lpil lpil marked this pull request as ready for review May 13, 2025 17:24
@lpil lpil merged commit 68be9b9 into main May 13, 2025
7 checks passed
@lpil lpil deleted the dynamic branch May 13, 2025 17:38
@@ -14,7 +14,7 @@ pub fn classify_false_test() {
}

pub fn null_test() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nil_test?

/// Create a dynamic value from a list, converting it to a sequential runtime
/// format rather than the regular list format.
///
/// On Erlang this will be a tuple, on JavaScript this wil be an array.
Copy link
Contributor

@inoas inoas May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be an array, wil => will

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants