-
Notifications
You must be signed in to change notification settings - Fork 45
Added/improved docstrings in Factory code #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also made some PEP8 improvement, e.g. renamed glideFactoryDowntimeLib methods
9001ba8
to
5cd011f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review feedback part 1/2: this round of review covers a major chunk of files that were modified (excluding files with large diffs which will be covered in part 2/2).
5cd011f
to
12169b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review feedback part 2/2: this round of review covers files with large diffs
2e8bf81
to
f8c410d
Compare
f8c410d
to
4d15a94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All review comments have been addressed/resolved and these changes are ready to be merged!
Added/improved docstrings in Factory code
Also fixed some Python3 compliance in a couple of factory tools.
For the docstrings, I used in part ChatGPT: