Added support for storing service attributes in the Consul KV store. #261
Conversation
Use by adding a 'servicePrefix=somepath' URL parameter to the consul:// URL
consul/consul.go
Outdated
| return r.client.Agent().ServiceDeregister(service.ID) | ||
| // pair := &consulapi.KVPair{Key: "service_attribute" + "/" + service.Name + "/" + k, Value: []byte(v)} | ||
| success := r.client.Agent().ServiceDeregister(service.ID) | ||
| r.client.KV().DeleteTree("service_attribute"+"/"+service.ID, nil) |
There was a problem hiding this comment.
"service_attribute" should be r.servicePrefix
|
It looks exactly like a solution I need at the moment. +1 for merging! |
|
Bear in mind I am a complete Go n00b, so handle with care ;-) |
|
I believe this was talked about in another issue. Into this general feature. Anybody want to give feedback on implementation? |
| return r.client.Agent().ServiceDeregister(service.ID) | ||
| // pair := &consulapi.KVPair{Key: "service_attribute" + "/" + service.Name + "/" + k, Value: []byte(v)} | ||
| success := r.client.Agent().ServiceDeregister(service.ID) | ||
| r.client.KV().DeleteTree("service_attribute"+"/attributes/"+service.ID, nil) |
There was a problem hiding this comment.
Again, shouldn't "service_attribute"+"/attributes/" be r.servicePrefix?
The test is passing, however that's because you ain't working with the return value for DeleteTree. The failure should be at least logged.
|
👍 |
|
+1 |
|
I'd really like to see this implemented. At the moment I'm storing attributes in a special consul tag, but this forces me to awkwardly search for this tag and split it into it's K/V combos every time I want to access one value. This change would really ease my life. 👍 |
|
Can we get some docs around how this would be used as part of this PR? Eg, in https://github.com/gliderlabs/registrator/tree/master/docs/user |
|
This pull request can be accepted? Why it is in standby? |
The general Service registration store in Consul does not support service attributes, but it always has a KV-store available.
Use by adding a 'servicePrefix=somepath' URL parameter to the consul:// URL