Add docker checks to consul backend #424
Conversation
| run within existing containers instead of from the Consul agent. | ||
|
|
||
| ```bash | ||
| SERVICE_DOCKER_CHECK_SCRIPT=/path/to/container/check |
There was a problem hiding this comment.
My expectation as a user would be that these checks would be registered using SERVICE_CHECK_DOCKER, not SERVICE_DOCKER_CHECK_SCRIPT. Former seems more consistent with other SERVICE_CHECK_* options.
There was a problem hiding this comment.
Can you update your pr to do this, @threetee ? This seems good otherwise.
There was a problem hiding this comment.
@threetee any chance you can address this? Would really like to use this functionality :)
|
Duplicate of #332? |
|
I'd be willing to take this over and submit a new PR if @threetee is no longer available. |
Slight rework taking into account comments in the thread and rebased off current master to avoid merge conflicts.
Slight rework taking into account comments in the thread and rebased off current master to avoid merge conflicts.
Slight rework taking into account comments in the thread and rebased off current master to avoid merge conflicts.
|
I'm not usually one to claim other peoples PRs but I would really like this feature implemented and the original author does not look to be active based on his profile. |
|
Bump, I could really use this, and things seem to be stagnating. |
Fixes #414. Also adds check string token substitutions for external host/port.