Add containerid in the service tags #471
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanndegat
force-pushed
the
add_containerid_in_tags
branch
from
633ac6f to
072c4a5
Compare
|
this is a nice enhancement to have, please consider to merge. thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A docker container can use service discovery tools to build up its configuration files.
For instance, some kind of service has to build the list of its peers, minus itself.
It is then useful to be able to filter nodes based on an criteria, like a unique id.
The only available id within a container being the "containerid", returned by "hostname",
this PR adds the containerid in the servicetags filed to be able to filter when querying the service discovery service.
It could have been added to the "serviceId" schema, but it would then lead to backward compatibility issues