fix: wa form test file

[priyanshu6238]

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request modifies a Cypress test file to align with updated WhatsApp forms API response structure where listWhatsappForms is renamed to whatsappForms with new revision metadata fields. Navigation patterns shift from using EditIcon to view-form controls, form creation no longer submits JSON payloads, and a validation error test is removed.

Changes

Cohort / File(s)	Summary
WhatsApp Forms Test Updates cypress/e2e/wa_forms/wa_form.spec.ts	API contract changes: renamed listWhatsappForms to whatsappForms; moved definition field into revision.definition nested structure. UI navigation: replaced EditIcon click with view-form control targeting. Form creation: removed formJson payload submission. Removed validation error test case. Updated test expectations to reflect read-only View route access pattern.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• added test cases for whatsapp forms #196: Modifies the same test file for comprehensive WhatsApp forms test cases including creation/validation flows; directly related to changes in API response structure and navigation patterns.
• Fix: WhatsApp Forms Cypress tests after icon updates and conditional rendering changes #200: Applies identical changes to the same test file—updates GraphQL response usage from listWhatsappForms to whatsappForms and changes navigation from EditIcon to view-form control.

Suggested labels

ready for review

Suggested reviewers

• shijithkjayan
• akanshaaa19
• AmishaBisht

Poem

🐰 The forms now wear revision clothing,
With nested metadata adorning,
ViewIcon routes replace the edits of old,
The JSON payload tale is left untold,
And validation tests? They've hopped away! 🌿

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix: wa form test file' is too vague and generic; it lacks specificity about what aspect of the test file is being fixed.	Consider a more descriptive title that captures the main change, such as 'fix: update WhatsApp form test to reflect API response schema changes' or 'fix: refactor wa form test navigation flow'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[shijithkjayan]

Don't we want this test? Are we not validating the json anymore?

[priyanshu6238]

No, in the new form builder, we have removed the JSON option from the Create WhatsApp Form page.

[shijithkjayan]

So where do we create the form json?

[priyanshu6238]

After publishing the form, we are redirected to the configuration page, where we create the form and then publish it.

[shijithkjayan]

@priyanshu6238 the CI is failing

[priyanshu6238]

@priyanshu6238 the CI is failing

it will fail , since it is point to some other frontend branch , run the cypress locally and change the frontend branch .the ci will pass

[priyanshu6238]

@priyanshu6238 the CI is failing

I have updated the description,please check the image above for reference.

[shijithkjayan]

So is this dependant on a front end PR? @priyanshu6238

[priyanshu6238]

So is this dependant on a front end PR? @priyanshu6238

yes .
pr- glific/glific-frontend#3689