-
Notifications
You must be signed in to change notification settings - Fork 6
Revert default language tab changes #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughVersion bump to 1.43.0-3 and refactoring of language selector logic: removed font-weight emphasis from active language styling, eliminated filtering of default languages from the selector component, and simplified fallback behavior to use a static DEFAULT_LANGUAGE constant instead of dynamically constructing named default tabs. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as Language Selector UI
participant State as Redux State
participant Store as Asset Store
rect rgb(200, 220, 230)
Note over UI,Store: Old Flow
UI->>State: Load flow definition
State->>Store: Check if chosen language exists
Store-->>State: Language not found
State->>Store: Scan assetStore.languages for default
Store-->>State: Return default language metadata
State->>State: Construct named tab (e.g., "Default (Name)")
State->>UI: Dispatch with dynamic default
end
rect rgb(220, 230, 200)
Note over UI,Store: New Flow
UI->>State: Load flow definition
State->>Store: Check if chosen language exists
Store-->>State: Language not found
State->>State: Use DEFAULT_LANGUAGE constant
State->>UI: Dispatch with static default
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
🧰 Additional context used🧬 Code graph analysis (1)src/store/thunks.ts (2)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The changes to the default language functionality were not backward compatible. Reverting these changes until we work on a better solution.
Summary by CodeRabbit
New Features
Style
Chores