Fix: Expression value not being saved in Wait for Response node

[priyanshu6238]

Summary by CodeRabbit

• Bug Fixes
  • Fixed timeout control so changing the timeout preserves any expression context. When an expression is active, the change now correctly reports both the numeric timeout and the expression; otherwise it reports the timeout alone. This ensures expression-mode selections are retained and propagated consistently.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The handleTimeoutChanged function in TimeoutControl now computes timeout from the selected value and, if an expression prop is present, calls onChanged(timeout, expression); otherwise it calls onChanged(timeout) with only the numeric timeout.

Changes

Cohort / File(s)	Summary
Timeout control handler modification src/components/form/timeout/TimeoutControl.tsx	handleTimeoutChanged now derives timeout from the selected value and conditionally includes expression when calling onChanged (calls onChanged(timeout, expression) if expression prop exists; otherwise onChanged(timeout)).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Specific focus: confirm expression prop availability is correct, callback signature accommodates the optional second argument, and no callers break from the changed call shape.

Poem

🐰 I nibble on code and cheer,
Timeout and phrase both near,
If an expression hops by,
I send it both, not just the sigh,
Little change — big gentle cheer!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: fixing expression values not being saved in the Wait for Response node, which aligns with the code change that now passes both timeout and expression to onChanged.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/wait_for_response_node

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b63e813 and 1801a2a.

📒 Files selected for processing (1)

• src/components/form/timeout/TimeoutControl.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/components/form/timeout/TimeoutControl.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Tests (16.x)
• GitHub Check: Coverage

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[akanshaaa19]

looks good