Skip to content

Conversation

@arsforza
Copy link
Contributor

@arsforza arsforza commented Dec 22, 2025

AB#39408

Describe your changes

  • fixed tokenCode passed with dashes ("-") exceeding the character number limit (19)
  • fixed dialog not hiding via X and backdrop click
  • refactored template
  • added to the frontend a check for tokenCode already assigned to current registration (it was throwing and unhandled 500 error)

Checklist before requesting a code review

  • I have performed a self-review of my code
  • I have addressed all Copilot comments
  • I have asked the design team to review these changes, or: The changes do not touch the UI/UX
  • I have added tests for my changes, or: Adding tests is unnecessary/irrelevant
  • I have made sure that all automated checks pass before requesting a review
  • I have updated all documentation where necessary
  • I have checked the list of integrations with the 121 API for changed endpoints
  • I do not need any deviation from our PR guidelines

Portal preview-deployment

https://happy-rock-0411d2003-7680.westeurope.3.azurestaticapps.net

@arsforza arsforza added the enhancement New feature or request that affects our end users label Dec 22, 2025
@arsforza arsforza added the bugfix Something that affects our end users is fixed label Dec 22, 2025
@arsforza arsforza force-pushed the arsforza/fix/link-visa-card-frontend branch from 08b0169 to c4d7109 Compare December 23, 2025 08:31
@arsforza arsforza marked this pull request as ready for review December 23, 2025 08:45
Copy link
Member

@elwinschmitz elwinschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some overlap with the review of:
#7655 (review)

tokenCodeToClean,
}: {
tokenCodeToClean: string;
}) => computed(() => tokenCodeToClean.replaceAll('-', ''));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 'just a pure function', right?
Does it need to be computed at all?

I don't think we need a lot of that Signal-magic-dust here...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also; I think we can even check for a bigger range of "weird characters people will use";

So we could "remove everything that is not a digit", by:

Suggested change
}) => computed(() => tokenCodeToClean.replaceAll('-', ''));
}) => computed(() => tokenCodeToClean.replace(/\D/g, '');

So it would catch (double) spaces, dashes, underscored, periods, comma's, etc...

[modal]="true"
[closable]="true"
[dismissableMask]="true"
[style]="{ width: '45rem' }"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be a safety-value for the min-width? Or a valid max-width?

That way, this dialog would became a lot more "safe for responsive use"...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something that affects our end users is fixed enhancement New feature or request that affects our end users

Development

Successfully merging this pull request may close these issues.

4 participants