-
Notifications
You must be signed in to change notification settings - Fork 28
Adding a logo url field to the token metadata api #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adding a logo url field to the token metadata api #132
Conversation
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
meiersi-da
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks from the perspective of an author of CIP-56 this looks like a sensible addition to me. I've also created the draft of the API changes we are talking about here:
They are backwards-compatible and easy to put in place.
@waynecollier-da @davidrichards-da : can you coordinate wrt how to get approval and how to ensure all wallet providers and asset issuers learn about this feature once it is supported?
Co-authored-by: Simon Meier <simon@digitalasset.com> Signed-off-by: Amanda L Martin <hythloda@gmail.com>
…-API Signed-off-by: Amanda L Martin <hythloda@gmail.com>
This PR adds a logo url field to the token metadata API. This has been a suggestion from multiple wallet providers and would enable token issuers the ability to add an image / logo to an asset providing consistent asset image visualization.