pull_request.yml: Check total reward weight change #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas-sbi
force-pushed
the
stas/make_sure_total_weight_doesnt_change_unless_expicitly_allowed
branch
17 times, most recently
from
39b1f34 to
377a223
Compare
Make sure total reward weight doesn't change unless explicitly allowed
by adding [allow-total-reward-weight-change] to the last commit message
Example outputs:
# Change disallowed
ERROR: Total reward weight diff for configs/DevNet/approved-sv-id-values.yaml is: 2. The change is not allowed. Add [allow-total-reward-weight-change] to the commit message to override.
INFO: Total reward weight diff for configs/MainNet/approved-sv-id-values.yaml is: 0.
INFO: Total reward weight diff for configs/TestNet/approved-sv-id-values.yaml is: 0.
# Change allowed
INFO: Total reward weight diff for configs/DevNet/approved-sv-id-values.yaml is: 2. The change is allowed.
INFO: Total reward weight diff for configs/MainNet/approved-sv-id-values.yaml is: 0.
INFO: Total reward weight diff for configs/TestNet/approved-sv-id-values.yaml is: 0.
stas-sbi
force-pushed
the
stas/make_sure_total_weight_doesnt_change_unless_expicitly_allowed
branch
from
377a223 to
007b8fc
Compare
Contributor
Author
|
We could also add a check against the actual weights when this information is available on some public endpoint to be accessed from GitHub Actions. |
stas-sbi
deleted the
stas/make_sure_total_weight_doesnt_change_unless_expicitly_allowed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure total reward weight doesn't change unless explicitly allowed by adding
[allow-total-reward-weight-change]to the last commit messageExample outputs: