-
Notifications
You must be signed in to change notification settings - Fork 14
process: Weight Check Automation & Resolution Process Draft #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hythloda
wants to merge
5
commits into
main
Choose a base branch
from
Weight-check-automation-resolution-process
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
828235d
Weight Check Automation & Resolution Process Draft
hythloda 3ea0e96
Merge branch 'main' into Weight-check-automation-resolution-process
hythloda 7edc7b8
Merge branch 'main' into Weight-check-automation-resolution-process
hythloda 607f068
Merge branch 'main' into Weight-check-automation-resolution-process
hythloda c516e0f
update from review
hythloda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| ## Weight Check Automation & Resolution Process | ||
|
|
||
| ### Purpose | ||
|
|
||
| Ensure that automated checks validate Super Validator weight configurations against on-chain votes and provide a clear resolution workflow for any discrepancies. | ||
|
|
||
| ### Process | ||
|
|
||
| #### 1. Re-enable automated weight checks | ||
| - GSF DevOps toggles the CI pipeline to run weight-consistency checks on every PR against `approved-sv-id-values.yaml` | ||
| - Checks fetch live on-chain weights and compare them to the YAML configuration | ||
|
|
||
| #### 2. Flag and notify | ||
| - On mismatch, CI creates an issue labeled `weight-check-failure` in the SV config repo | ||
|
|
||
| #### 3. Assign responsibility | ||
| - The originator of the weight-change proposal must resolve any flagged errors | ||
| - If no PR corresponds to a recent vote, that vote should be voted down by default | ||
|
|
||
| #### 4. PR creation and correction | ||
| - As per Itai’s guidance, the proposal originator opens the PR and references it in the vote request | ||
| - The originator must update the PR to clear all CI flags before merging | ||
|
|
||
| #### 5. Merge permissions | ||
| - By default, PRs can't be reviewed by employees of the same organisation that submitted a vote. | ||
| - IEU staff may merge weight-change PRs internally provided that: | ||
| - One individual submits the PR and a different individual merges it | ||
| - All CI checks pass | ||
|
|
||
| #### 6. Visibility and reporting | ||
| - CI results and open failure issues remain publicly visible in the SV config repository | ||
|
|
||
| #### 7. Escalation | ||
| - Unresolved errors older than 48 hours trigger notification of the GSF governance team | ||
|
|
||
| --- | ||
|
|
||
| ### Background & Related Automations | ||
|
|
||
| - GSF now handles many parallel weight changes; automated checks prevent configuration drift | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.