Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add charts #589

Open
wants to merge 55 commits into
base: main
Choose a base branch
from
Open

feat: add charts #589

wants to merge 55 commits into from

Conversation

brc-dd
Copy link
Member

@brc-dd brc-dd commented Mar 3, 2025

image

Variants:

  • Bar Chart - Horizontal

    image
  • Pie Chart

    image
  • Donut/Pie Chart - Half

    image
  • Donut/Pie Chart - With Labels

    image
  • Donut/Pie Chart - With Active Slice

    image
  • Light mode

    image


Story

Notes:

  • svg margins have sensible defaults wherever possible, but it might need bit of hit-and-trial when using the components depending on the content
  • in pie chart, enabling both legend and labels at same time is not supported and there might be some content overlap

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for sefirot-story ready!

Name Link
🔨 Latest commit c6b0953
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-story/deploys/67d1daaaa26522000868d2f1
😎 Deploy Preview https://deploy-preview-589--sefirot-story.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for sefirot-docs ready!

Name Link
🔨 Latest commit c6b0953
🔍 Latest deploy log https://app.netlify.com/sites/sefirot-docs/deploys/67d1daaae42ece00089f2f32
😎 Deploy Preview https://deploy-preview-589--sefirot-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd brc-dd marked this pull request as ready for review March 4, 2025 03:41
@brc-dd brc-dd requested a review from kiaking as a code owner March 4, 2025 03:41
@brc-dd brc-dd marked this pull request as draft March 4, 2025 19:42
@brc-dd brc-dd marked this pull request as ready for review March 5, 2025 21:41
@kiaking
Copy link
Member

kiaking commented Mar 12, 2025

@brc-dd
Very impressive! Really cool. Can we add these options?

  • Control thickness of the bar, both bar and donut.
  • Add option to control font size of label and legends.
    • Including tick values in bar char like 2022, 2023, 2024, etc
    • So that we can have smaller font size when chart is small
  • Maybe change :mode prop to :type or :variant? Because in Sefirot, mode usually refers to color style in other components 👀 I think we don't need to change :colors to :mode since :colors actually take multiple colors. If we were to add :mode, maybe it would be something like mode="monochrome" kinda thing 🤔
  • Maybe set Pie chart border radius to 0?

Other than this, it looks very very good. After this, let me adjust a tiny bit on stylings like tooltip padding, default thickness of the bar by talking to Keity how he wants it to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants