fix: apply SCTE35 from EXT-X-CUE-OUT-CONT lines#416
Open
gaoflow wants to merge 1 commit into
Open
Conversation
When EXT-X-CUE-OUT-CONT includes a SCTE35= attribute but no Duration=, the SCTE35 value was silently ignored due to a copy-paste error in the condition check (duration used in place of scte35).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_cueout_conthad a copy-paste bug: the SCTE35 attribute from#EXT-X-CUE-OUT-CONTlines was only applied when aDuration=attribute was also present, because the condition checkedif duration:instead ofif scte35:.When a CUE-OUT-CONT line carried
SCTE35=withoutDuration=, the value was silently lost.The bug
This PR was assisted by an AI language model (Claude) under my direction.