Skip to content

fix: replace string ref with React.createRef() in Toolbar component #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
samuelnakazawa merged 1 commit into from
Nov 13, 2025
Merged

fix: replace string ref with React.createRef() in Toolbar component #460

samuelnakazawa merged 1 commit into from
Nov 13, 2025

Conversation

@ritoban23
Copy link
Contributor

@ritoban23 ritoban23 commented Oct 23, 2025

Related Issue

Fixes #373

Proposed Changes

  • Replace deprecated string ref "toolbarWrapper" in Toolbar.js with React.createRef()
  • Update constructor to initialize toolbarWrapperRef
  • Use ref={this.toolbarWrapperRef} in the Toolbar render method
  • All tests pass and no new warnings are introduced

@samuelnakazawa samuelnakazawa merged commit a0eebfd into globocom:master Nov 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warning: A string ref, "toolbarWrapper", has been found within a strict mode tree.

2 participants

@ritoban23 @samuelnakazawa