Added install make/tox recipes; modified contributing doc #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derek-globus
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
kurtmckee
reviewed
Nov 12, 2025
sirosen
reviewed
Nov 12, 2025
kurtmckee
approved these changes
Nov 12, 2025
sirosen
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
install-venvwhich installs a tox environment as though it were a virtual environment at./.venvmake installwhich installs a virtualenv and pre-commitWhy?
The steps to get an IDE set up to function with the SDK is not apparent from the contributing docs.
Even if IDEs are not the exclusive development environment used by sdk contributors they are a core one. We should have a simpler path to encourage contribution from new contributors.
Testing
make clean && make install