Skip to content

Port environment to nanobind#1291

Merged
joaander merged 64 commits intonanobindfrom
nanobind-environment
Feb 4, 2025
Merged

Port environment to nanobind#1291
joaander merged 64 commits intonanobindfrom
nanobind-environment

Conversation

@DomFijan
Copy link
Contributor

@DomFijan DomFijan commented Nov 1, 2024

Description

Part of nanobind porting efforts.

Progress

  • AngularSeparation
  • BondOrder
    • Compiles
    • Tests pass
  • LocalBondProjection
  • LocalDescriptors
    • Compiles
    • Tests pass
  • EnvironmentMatching

How Has This Been Tested?

Previous testing infrastructure is being reused.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are a few TODO items that need to be addressed or removed.

@joaander joaander marked this pull request as ready for review February 3, 2025 17:20
@joaander joaander force-pushed the nanobind-environment branch from abc3b50 to b200a8d Compare February 3, 2025 20:33
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joaander joaander merged commit af99cc9 into nanobind Feb 4, 2025
33 checks passed
@joaander joaander deleted the nanobind-environment branch February 4, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants