Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
append_microstateforSpherical<3>,Spherical<4>,Hyperbolic<3>, andOrientedHyperbolicPoint<3, Angle>.Motivation and context
append_microstateis necessary to save Monte Carlo trajectories as GSD files. The four aforementioned manifold types are currently the four supported non-Euclidean manifold types.How has this been tested?
This PR includes unit tests for each of the four manifold types with every relevant combination of boundary conditions. I have also been using these functions for production simulations and verified that they work as intended.
Checklist:
doc/src/credits.md) in the pull request source branch.release-notes.mdfollowing the established format.