Open
Conversation
bdice
approved these changes
Jan 5, 2026
| return "fa-file-excel" | ||
| if "powerpoint" in mtype or "presentation" in mtype: | ||
| return "fa-file-powerpoint" | ||
| if "x-" in mtype or "json" in mtype: |
Member
There was a problem hiding this comment.
Maybe tighten this up a bit, since x- is pretty broad:
Suggested change
| if "x-" in mtype or "json" in mtype: | |
| if mtype.startswith("application/x-") or "json" in mtype: |
Contributor
Author
There was a problem hiding this comment.
Actually, on further review, I'm a bit unsure how to handle this -- "x-" is quite broad, but both "application/x-" and "text/x-" are required to handle all common code cases, which ends up falling back to the same behavior as far as I know. We could use something like content-types, but that's an extra dependency. Let me know your thoughts
Member
There was a problem hiding this comment.
No big deal. We can go with "x-" in mtype if it works well for your needs. Let's avoid another dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The FileList module can now display file icons next to the filenames. This is (in my opinion) a nice feature to have, and opens up a solution for #73, which could use the icons as handles for the file preview popup or as a download button.
Motivation and Context
Checklist: