feat(inventory): Add ESET Antivirus inventory support across macOS, Linux, and Windows

[eduardomozart]

📋 Overview

This pull request introduces comprehensive inventory and license detection support for ESET Endpoint Security and ESET Endpoint Antivirus across macOS, Linux, and Windows. It also harmonizes product naming across all three operating systems to ensure consistent inventory reporting entries on GLPI Server.

---

🚀 Key Changes

🍎 macOS Support (New & Enhanced)

• AntiVirus Module (MacOS::AntiVirus::ESET):
  • Added detection for ESET Endpoint Security and ESET Endpoint Antivirus application bundles in /Applications/.
  • Status Verification (ENABLED): Verifies active protection by combining two reliable checks:
    1. Daemon Verification: Uses built-in GLPI::Agent::XML to read /Library/LaunchDaemons/com.eset.protection.plist, extract the daemon execution binary (startd), and verify it is running in process lists via getProcesses. If the plist cannot be read, it safely falls back to checking $basepath/startd.
    2. Real-time Protection Status: Parses /Library/Application Support/ESET/Security/var/confd/settings.json using Cpanel::JSON::XS to verify that real-time file system protection (RTFSEnabled) is active (ce_val == 1).
  • Update Heuristics: Collects license expiration dates from lic --status and calculates an up-to-date heuristic by evaluating detection engine modules from upd --list-modules.
  • Shell-Safe Execution: Uses array reference command invocations (e.g., [ "$basepath/upd", "--list-modules" ]) to prevent shell word splitting on bundle paths containing spaces.
  • Dynamic Fallback Resolution: Automatically resolves product names from the application bundle directory path if Product name: is omitted from command outputs.
• License Inventory (MacOS::License):
  • Extracts ESET Public ID from lic --status and populates the LICENSEINFOS inventory section.

🐧 Linux & 🪟 Windows Support

• Product Name Harmonization (MacOS::License, Linux::AntiVirus::EEA): Automatically strips OS-specific product suffixes (e.g., " for macOS", " for Linux", " for Windows") when creating LICENSEINFOS entries. This ensures the license name exactly matches the SOFTWARES inventory and its Windows counterpart.
• Windows Registry Enhancements (Win32::License): Updated registry traversal to prioritize native 64-bit registry paths (HKLM\SOFTWARE\...) before falling back to Wow6432Node when querying ESET license GUIDs and Publisher data.

---

🧪 Testing & Verification

All unit test suites and mock resources have been updated and verified across isolated environments without warnings:

• t/tasks/inventory/macos/antivirus/eset.t — Verifies ESET macOS inventory parsing, plist XML handling, JSON settings evaluation, and dynamic bundle fallbacks.
• t/tasks/inventory/macos/license-eset.t — Verifies macOS ESET license extraction and suffix stripping.
• t/tasks/inventory/linux/antivirus/eea.t — Verifies Linux EEA inventory and license suffix stripping.
• t/tasks/inventory/windows/license.t — Verifies Windows 64-bit/32-bit registry license lookup.

[g-bougard]

Hi @eduardomozart

thank you for your PR.

Anyway, I saw a lot of problems.

[eduardomozart]

I've just pushed a new commit to address your points:

Linux License Segregation & %params

• Reverted the %params injection in Linux::AntiVirus::EEA::_getEEAInfo to keep it clean, relying just on logger.
• Completely separated the ESET License logic from the AntiVirus inventory. I've created a dedicated Linux::License module and a Linux::License::EEA submodule, mirroring the architecture you suggested.

Windows Refactoring

• Added InstallDir to the mocked registry .reg file (with proper UTF-16LE encoding) so ermm.exe correctly dynamically resolves its install path during the inventory sweep.
• Removed the manual SOFTWARE/ESET/... nested hash traversal in Win32::License that was polluting the core code. It now relies cleanly on the leaf node passed directly from loadRegistryDump during test mocks.

macOS Polish & Fixes

• Implemented your suggested parsing loop using empty($line) from GLPI::Agent::Tools across both the Linux and macOS license parser loops.
• Fixed a bug where lic -status was accidentally passed instead of lic --status, restoring the proper extraction of the "Expiration Date".
• Fixed a bug where getAllLines was mutating the %params arguments incorrectly, ensuring ENABLED parses active protection properly again.

General Cleanup

• Addressed all trailing whitespaces, duplicate variable declarations, and syntax issues. The full test suite (t/03var.t, t/07whitespaces.t, and all unit tests) is passing completely green locally.

[g-bougard]

Hi @eduardomozart

here we are also next to a merge.

I still see few required optimization and syntax quirks to fix.

Can check my comments ?

Thank you

[eduardomozart]

Done!

[g-bougard]

Test is failing on windows. It seems you made a mistake on _test_date in macos eset av test.

Check my comments below.