Helpdesk home page config for entities#19355
Conversation
AdrienClairembault
force-pushed
the
home-config-entity
branch
2 times, most recently
from
08454c5 to
f12d4cf
Compare
There was a problem hiding this comment.
To review with whitespace off, lot of indentation changes due to some code being nested in new content.
AdrienClairembault
force-pushed
the
home-config-entity
branch
from
f12d4cf to
8a8b4ac
Compare
AdrienClairembault
force-pushed
the
home-config-entity
branch
from
8a8b4ac to
74d3797
Compare
orthagh
left a comment
orthagh
left a comment
There was a problem hiding this comment.
Globally OK.
Just a quick question as I don't see any install/update changes.
How is the homepage after making an upgrade or installing a new GLPI ?
The changes are in the default data manager: https://github.com/glpi-project/glpi/pull/19355/files#diff-0be704a1020094b7c94da8d290c41efbbe5a0da5aa8a40f54e04b228ce395591 The default tiles are attached to the root entity (previously it was all self service profiles found during the update/install). |
| } | ||
|
|
||
| #[Override] | ||
| public function getConfigInformationText(): ?string |
There was a problem hiding this comment.
Please note that this method name is not really helping in th Entity context. It should be changed, but please do it in another PR so we can merge this one and integrate it in the 11.0.0-beta release.
|
This PR has been is closed and has been automatically locked. Please open a new issue with all requested information for related bugs. |
3 participants
Checklist before requesting a review
Description
Allow the helpdesk home page to be configured by entity.
The first commit is from #19321, which should be merged first (wait for it to be merged before reviewing).
Screenshots
Config on an entity;
Config on a profile:
On an entity that does not have any values, we should the parent values instead:
The two actions allow to define your own values for this entity (starting from an empty list of tiles or from a copy of the parent tiles).