Sudo mode (poc to review)#23221
Closed
SebSept wants to merge 6 commits into
Closed
Conversation
No behavior change expected. Still can be improved, just a step to make init() more readable.
…ther pr. No behavior change expected. Still can be improved, just a step to make init() more readable.
sudo mode on /front/user.form.php , see src/Glpi/Http/Firewall.php:227
just for demo, no need to protect this page.
cedric-anne
reviewed
Feb 25, 2026
cedric-anne
left a comment
cedric-anne
left a comment
Member
There was a problem hiding this comment.
The logic seems OK, but it would require to declare all routes that must be protected. I think it is preferable, as automatic protection may be too agressive, but it will requires a time-consuming audit/review to validate that all expected cases are covered.
cconard96
reviewed
Feb 26, 2026
Merged
4 tasks
Contributor
Author
|
-> #23447 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://outline.teclib.com/doc/sudo-mode-admin-session-PWWDQgyg5l
Just a POC to review architecture
works will all kind of controllers (legacy (existing file), explicit Sf controller, generic controllers)).
Prerequisites for testing:
Protected routes: