FIX / Fix authentication settings not being saved#24251
Merged
trasher merged 1 commit intoMay 19, 2026
Conversation
stonebuzz
approved these changes
May 19, 2026
trasher
approved these changes
May 19, 2026
Rom1-B
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When saving changes from
Configuration > Authentication > Setup, the form posts toconfig.form.php, which only handles this flow whenupdate_authis present and non-empty. The submit button was sendingupdate_authwithout a value, so the request was not processed by the authentication settings update branch. As a result, the request fell back to the generic configuration page and the changes were not saved.This change adds an explicit value to the
update_authsubmit button so the authentication settings save flow is correctly triggered.