refactor(ModuleLifter): update liftModule signature - #677
Merged
Conversation
Snowy1803
reviewed
Oct 23, 2025
Snowy1803
left a comment
Snowy1803
left a comment
Member
There was a problem hiding this comment.
You need to add any StructDecl or EnumDecl created within the (DI)TypeLifter to the ModuleDecl as well
…avoid creating multiple decls
…outineType and updating method signatures
…te type handling in detectExternalFunctions
…g support for external functions, structs, and enums, while improving debug info handling
badermarouan
force-pushed
the
feature/change-modulelifter-to-create-an-astmoduledecl-containing-functiondecls-instead-of-gilmodule-and-gilfunction
branch
from
October 24, 2025 13:03
4ef71b3 to
39625b3
Compare
Snowy1803
reviewed
Oct 24, 2025
badermarouan
enabled auto-merge
October 24, 2025 13:26
badermarouan
deleted the
feature/change-modulelifter-to-create-an-astmoduledecl-containing-functiondecls-instead-of-gilmodule-and-gilfunction
branch
October 24, 2025 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #669