Update 1D Profile viewer to use wcsaxes - Add slice function to 1D Profile viewer with sliders to select point#2248
Draft
nabobalis wants to merge 5 commits intoglue-viz:mainfrom
Draft
Update 1D Profile viewer to use wcsaxes - Add slice function to 1D Profile viewer with sliders to select point#2248nabobalis wants to merge 5 commits intoglue-viz:mainfrom
nabobalis wants to merge 5 commits intoglue-viz:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2248 +/- ##
==========================================
- Coverage 88.15% 87.92% -0.24%
==========================================
Files 247 249 +2
Lines 23316 23438 +122
==========================================
+ Hits 20554 20607 +53
- Misses 2762 2831 +69
Continue to review full report at Codecov.
|
f6355f2 to
da1797f
Compare
95b08fb to
3193d73
Compare
nabobalis
commented
Feb 7, 2022
Comment on lines
+209
to
+212
| # TODO: This should not be here. | ||
| # I can not work out how to get this to be set at initialisation. |
Contributor
Author
There was a problem hiding this comment.
This needs fixing, I just have yet to work it out yet.
3193d73 to
acafa6f
Compare
a3027f3 to
bcee99a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase and update of #2167
As far as I can tell it this PR is meant to add:
Forces WCSAxes to be used for the .1D Profile viewer
A new slice function that allows a user to get the 1D data at a point
The slice function uses a new widget to allow selection of the point via two sliders
TODO: