Fix build with 1.81 #968
Merged
Fix build with 1.81 #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 1.81, `stringify` appears to always insert spaces between tokens, resulting in type names like `std :: io :: File`. Switching to `concat` avoids this issue. Due to the use of `local_inner_macros`, we fully qualify `concat` and `stringify` in the definition of `field_decl_inner`.
Marwes
requested changes
Dec 4, 2024
Member
Marwes
left a comment
Marwes
left a comment
There was a problem hiding this comment.
Thanks! CI is failing due to the lockfile being old, causing some nightly issues in dependencies, a cargo update should take care of it.
Marwes
approved these changes
Dec 6, 2024
|
@Marwes any plan to cut a new release? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 1.81,
stringifyappears to always insert spaces between tokens, resulting in type names likestd :: io :: File. Switching toconcatavoids this issue.Due to the use of
local_inner_macros, we fully qualifyconcatandstringifyin the definition offield_decl_inner.Fixes #966.
Fixes #967.