Add non-predictive text keyboard type#445
Merged
jperedadnr merged 2 commits intogluonhq:masterfrom May 6, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new KeyboardType intended to request a “non-predictive text” keyboard (primarily for Android), and adds an iOS-side fallback because iOS currently has no equivalent for disabling suggestions/predictive text via keyboard type.
Changes:
- Add
KeyboardType.TEXT_NO_SUGGESTIONS(12)API constant with documentation. - Add iOS native fallback that maps unsupported values (including
12) toUIKeyboardTypeASCIICapable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| modules/keyboard/src/main/native/ios/Keyboard.m | Adds range checking/fallback for unsupported keyboard type values on iOS. |
| modules/keyboard/src/main/java/com/gluonhq/attach/keyboard/KeyboardType.java | Adds the new TEXT_NO_SUGGESTIONS enum constant and its Javadoc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+105
to
+109
| * A text keyboard with autocorrection, suggestions and predictive text | ||
| * disabled. Useful for fields that should accept raw user input | ||
| * (identifiers, codes, tokens, login input). | ||
| * | ||
| * <p>On iOS this value fall back to an ASCII-capable keyboard.</p> |
Comment on lines
+104
to
+111
| /** | ||
| * A text keyboard with autocorrection, suggestions and predictive text | ||
| * disabled. Useful for fields that should accept raw user input | ||
| * (identifiers, codes, tokens, login input). | ||
| * | ||
| * <p>On iOS this value fall back to an ASCII-capable keyboard.</p> | ||
| */ | ||
| TEXT_NO_SUGGESTIONS(12); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up of 165, add a new keyboard type, mainly for Android, that can be used to have text input controls without predictive text (even if user keeps the predictive text enabled in the device settings).
On iOS there is no predictive support yet.