Fix resolving and connecting to devices which have different short and full device names#455
Open
hohteri wants to merge 1 commit into
Open
Fix resolving and connecting to devices which have different short and full device names#455hohteri wants to merge 1 commit into
hohteri wants to merge 1 commit into
Conversation
…d full device names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS if you had a device which had different short and full name, the full name was never updated to the device reference listening for BleDevice.State changes. This is fixed in
gotPeripheralmethod. Once this was fixed, it was not possible to connect to the ball as adeviceNameslist was maintained. As thegotPeripheralnow correctly updates the correct device instance with the updated name, there is no need for separatedeviceNameslist but one can iterate throughdeviceslist instead.