Skip to content

Try to add support for passing --args to nativeRunAgentTask just Application's run task is accepting already! #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ctoabidmaqbool1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try to add support for passing --args to nativeRunAgentTask just Application's run task is accepting already! #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ repositories {
maven {
url "https://central.sonatype.com/repository/maven-snapshots/"
}
mavenLocal()
}

dependencies {
Expand All @@ -36,7 +37,7 @@ gradlePlugin {
implementationClass = 'com.gluonhq.gradle.GluonFXPlugin'
website = 'https://github.com/gluonhq/gluonfx-gradle-plugin'
vcsUrl = 'https://github.com/gluonhq/gluonfx-gradle-plugin'
tags.set([ 'java', 'javafx', 'gluon', 'client', 'substrate', 'graalvm', 'aot' ])
tags.set(['java', 'javafx', 'gluon', 'client', 'substrate', 'graalvm', 'aot'])
}
}
}
Expand Down
21 changes: 21 additions & 0 deletions src/main/java/com/gluonhq/gradle/tasks/NativeRunAgentTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
import java.util.List;
import java.util.Locale;

import org.gradle.api.tasks.Internal;
import org.gradle.api.tasks.Input;
import org.gradle.api.tasks.options.Option;

public class NativeRunAgentTask extends NativeBaseTask {

private static final String AGENTLIB_NATIVE_IMAGE_AGENT_STRING =
Expand All @@ -64,12 +68,24 @@ public class NativeRunAgentTask extends NativeBaseTask {

private final ClientExtension clientExtension;

private List<String> applicationArgs = new ArrayList<>();

@Inject
public NativeRunAgentTask(Project project) {
super(project);
clientExtension = project.getExtensions().getByType(ClientExtension.class);
}

@Option(option = "args", description = "Arguments to pass to the application")
public void setApplicationArgs(List<String> args) {
this.applicationArgs = args;
}

@Internal
public List<String> getApplicationArgs() {
return applicationArgs;
}

@TaskAction
public void action() {
getProject().getLogger().info("ClientNativeRunAgent action");
Expand Down Expand Up @@ -113,6 +129,11 @@ public void action() {
var jvmArgs = List.of(AGENTLIB_NATIVE_IMAGE_AGENT_STRING);
execTask.getJvmArgumentProviders().add(() -> jvmArgs);

// set application args
if (applicationArgs != null && !applicationArgs.isEmpty()) {
execTask.args(applicationArgs);
}

// run
execTask.exec();
} catch (Exception e) {
Expand Down