posix ops: call posix_inode_ctx_get_all() only if needed #4360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some functions (posix_writev, fallocate, ...) it is used to be called unconditionally. However, it doesn't need to be - only when we need ctx to do locking. Updates: gluster#1000 Signed-off-by: Yaniv Kaul <[email protected]>
|
CLANG-FORMAT FAILURE: index ebb0795e4..dd2d053e9 100644
--- a/xlators/storage/posix/src/posix-inode-fd-ops.c
+++ b/xlators/storage/posix/src/posix-inode-fd-ops.c
@@ -6032,10 +6032,7 @@ posix_readdirp(call_frame_t *frame, xlator_t *this, fd_t *fd, size_t size,
if (op_ret >= 0) {
op_ret = 0;
- list_for_each_entry(entry, &entries.list, list)
- {
- op_ret++;
- }
+ list_for_each_entry(entry, &entries.list, list) { op_ret++; }
}
STACK_UNWIND_STRICT(readdirp, frame, op_ret, op_errno, &entries, NULL); |
|
/run regression |
|
1 test(s) failed 0 test(s) generated core 3 test(s) needed retry |
|
/run regression |
|
0 test(s) failed 1 test(s) generated core 2 test(s) needed retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some functions (posix_writev, fallocate, ...) it is used to be called unconditionally. However, it doesn't need to be - only when we need ctx to do locking.
Updates: #1000
Signed-off-by: Yaniv Kaul [email protected]