WIP: Address python linter complaints #4488
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
ThalesBarretto
force-pushed
the
thales_address_python_linter_complaints
branch
4 times, most recently
from
217604b to
a684b73
Compare
ThalesBarretto
changed the title
|
/run regression |
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
…ibgfchangelog.py
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
…hanges.py
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
ThalesBarretto
force-pushed
the
thales_address_python_linter_complaints
branch
from
a684b73 to
d456543
Compare
ThalesBarretto
commented
Mar 1, 2025
| import sys | ||
|
|
||
| from generator import ops, fop_subs, cbk_subs, generate | ||
|
|
There was a problem hiding this comment.
do not change the template strings
ThalesBarretto
force-pushed
the
thales_address_python_linter_complaints
branch
2 times, most recently
from
8a2389d to
8815c0e
Compare
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
ThalesBarretto
force-pushed
the
thales_address_python_linter_complaints
branch
from
8815c0e to
c2bd603
Compare
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
…er.py
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs.
This commit silences most of the python linter complaints
without any functional changes. The changes include mostly formatting
and missing obvious docstrings. We left out dependency and exception
handling complaints on purpose to be addressed separately.
Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit silences most of the python linter complaints without any functional changes. The changes include mostly formatting and missing obvious docstrings. We left out dependency and exception handling complaints on purpose to be addressed separately. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
ThalesBarretto
force-pushed
the
thales_address_python_linter_complaints
branch
from
c2bd603 to
f30e199
Compare
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes to "raw" strings for regex operations. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes unassigned strings to comments. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes a syntax error for checking when checking for membership with "for not x in group" to "for x not in group". Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. Changes a comparison to literal value done with "is" to "==". Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
This series aim to reduce the python linter build logs. This commit changes unassigned strings to comments. Signed-off-by: Thales Antunes de Oliveira Barretto <[email protected]>
ThalesBarretto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the python linter logs test mostly ok, but they are filled with warnings.
IMHO that's a lot of noise, and almost all the fixes are really trivial.
To the record we:
Reference : 1736 flake8 issues , pylint rating 6.12/10.
Last build: 232 flake8 issues , pylint rating 6.81/10.
This series addresses the TRIVIAL linter warnings.