Add support for user.openshift.io resources#244
Open
Patrickdsa00 wants to merge 4 commits into
Open
Conversation
…s.yaml additions for user.openshift.io resources
Owner
|
Hey @Patrickdsa00, thank you for the PR. It is incomplete. The YAML resource deserialization won't work without the resources' types referenced in RawObjectToRuntimeObject function. Also, please add the resources' type here as well: here. |
…, Group, and Identity types in deserializer - Add type handlers in know-types.go - Register user types in schema initialization
Author
|
Hello @gmeghnag, thanks for reviewing it. I've just made a commit with the suggested changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor change in the
cmd/get/known-resources.yamlfile has the purpose of adding support to getUsers,Groups, andIdentitiesresources (from theuser.openshift.iogroup) with the commandomc get, when those resources are collected withoc adm inspect groups,users,identities.