Improving speed of layouting#92
Open
soniccat wants to merge 1 commit intogmoledina:masterfrom
soniccat:master
Open
Improving speed of layouting#92soniccat wants to merge 1 commit intogmoledina:masterfrom soniccat:master
soniccat wants to merge 1 commit intogmoledina:masterfrom
soniccat:master
Conversation
|
Maybe I'm wrong, but this code is very similar to another performance improvement that was committed then withdrawn a while ago. While it's useful in speeding up scrolling (I have similar code in a private build), it apparently caused problems for some developers. Not quite sure why my use case isn't giving me the same problems (perhaps because I'm not allowing reordering)... |
Author
|
Hmm it means that I will change the library in different places when I will use it) |
|
There are something wrong in the editing status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just downloaded your library and started analyze source code. It's a nice written project).
But I found that setSubviewsCacheAsInvalid is called in every layoutSubviews call. I think that it's wrong to clear cache when I scroll by 1 pixel. We should do this only if we have new cells to load.
Am I wrong?