Fixes White Text-boxes on Free GPM #64 #69
Open
Alipoodle wants to merge 9 commits intogmusic-utils:masterfrom
Open
Fixes White Text-boxes on Free GPM #64 #69Alipoodle wants to merge 9 commits intogmusic-utils:masterfrom
Alipoodle wants to merge 9 commits intogmusic-utils:masterfrom
Conversation
Contributor
Author
|
Well nearly fixed... it found an error with Light theme when it at the top of a playlist the shows different Artists |
Alipoodle
commented
Mar 25, 2017
| color:<<FORE_PRIMARY>>; | ||
| } | ||
| .qp #material-one-middle .material-search, .qp #material-one-middle .material-search:focus { | ||
| background-color: rgba(255,255,255,0.16); |
Contributor
Author
There was a problem hiding this comment.
I kept this line in each of them, because I felt that it would save space, rather than adding it to the common.css
Contributor
Author
|
^ |
| color:<<FORE_PRIMARY>>; | ||
| } | ||
| .qp #material-one-middle .material-search, .qp #material-one-middle .material-search:focus { | ||
| background-color: rgba(255,255,255,0.16); |
Member
There was a problem hiding this comment.
This should be something like <<ALPHA 0.84>><<FORE_PRIMARY>><</ALPHA>>
(Not sure of exact syntax)
Contributor
Author
There was a problem hiding this comment.
Let me test that, to make sure!
| background-size: 40px 40px; | ||
| } | ||
| input.material-search.label-input-label::-webkit-input-placeholder { | ||
| color: #212121 !important; |
Member
There was a problem hiding this comment.
These colors should use the variables not be hardcoded 👍
Contributor
Author
There was a problem hiding this comment.
As in using <<BACK_PRIMARY>>?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-#2129
and #64
This fixes the problem for Light / Dark theme's search boxes showing up as White (Images can be found on First Issue.)
The reason for the issue is most likely the change in how GPM themed the Search box from being Transparent to solid white.
Light theme:
Dark theme:
