Reduce metrics sent to Datadog from the UI fedev-3993#2638
Open
timgmxio wants to merge 1 commit into
Open
Conversation
Deploying gmx-interface-home with
|
| Latest commit: |
9260eda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc169f68.gmx-interface-home.pages.dev |
| Branch Preview URL: | https://datadog-log-volume-optimizat.gmx-interface-home.pages.dev |
Deploying gmx-interface with
|
| Latest commit: |
9260eda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4282f310.gmx-interface.pages.dev |
| Branch Preview URL: | https://datadog-log-volume-optimizat.gmx-interface.pages.dev |
Playwright Component Test ReportAll tests passed. Commit 9260eda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datadog log volume optimization
Identical infra-event storms (broken RPC × every open tab × fleet) dominate our Datadog log volume. This PR cuts the noise without losing signal.
Changes
multicall.timeout,multicall.error,worker.multicall.error,rpcTracker.endpoint.updated,error): first occurrence is sent as-is, identical repeats within a 60s window are folded into one summary event withrepeatCount/firstSuppressedAt/lastSuppressedAt. Hidden tabs (the main storm source) hold even the first event until the tab becomes visible or unloads.AbortError, "user aborted a request", "operation was aborted", Firefox "dead object", and transport blips in the Gelato gas-tank poll.multicall.timeout+ timeout counter), it is no longer also reported asmulticall.error+ error counter.callsCount→callsCountBucket("1-10" … "500+") inmulticall.batched.*to cap server-side metric-key cardinality.HttpClientandcreateTimeoutSignalnow abort withHttpTimeoutError/TimeoutErrorinstead of a plainAbortError, so the new abort filter can't swallow real backend timeouts.account(connected wallet) to global metric fields — lets support match a user's report to their event timeline.multicall.request.errorcounter now sendsrequestType: "retry"for fallback requests (was hardcoded"initial").Metrics.spec.tscovering coalescing and the ignored-error filter.callsCountfield is gone → usecallsCountBucket(string). Facets/filters oncallsCountwill be empty.multicall.request.errorcounter: timeouts are no longer counted (usemulticall.request.timeout);requestType:"retry"appears for the first time.multicall.errorevent count drops — RPC timeouts are no longer duplicated into it.count + sum(repeatCount), notcount. Summaries arrive up to 60s late (from hidden tabs — only when the tab returns to visibility).errorevent baseline drops — aborts/browser noise and Gelato transport blips are filtered out.AbortError("The user aborted a request") →HttpTimeoutError/TimeoutError. Saved searches on the old messages won't match.