Proposed Solution to Issue 171 - #274
Open
behrens-web wants to merge 2 commits into
Open
Conversation
added 2 commits
May 12, 2021 14:02
Signed-off-by: Samuel Behrens <behrens.sam@uwlax.edu>
Signed-off-by: Samuel Behrens <behrens.sam@uwlax.edu>
Member
|
Hey @behrens-web This is a great start. Quick comment: can you avoid committing changes to files that are not relevant to the PR? I am not sure what were the changes (Github diff says "empty file") but they were probably some minor changes. I assume you are not that familiar with git yet. It will help if you can do something like this:
Once I can see only the relevant changes, I will also be able to compile and try the changes on my system. best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project I just submitted should display the number of accepted jobs and total jobs when the "Req Mgr" button is pressed on gngr. Accepted jobs will be on the left side of the "OK" button whereas Total jobs will be on the right side of the "OK" button.
I look forward to your input on my contribution.