WIP fix(gnovm): PoC of inter-realm spec #2958
Conversation
ltzmaxwell
requested review from
jaekwon,
moul,
piux2,
thehowl,
mvertes and
a team
as code owners
github-actions
bot
added
🧾 package/realm
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
jefft0
added
review/triage-pending
|
(The "review team" label was added by mistake. This PR is opened by a core dev.) |
| // PKGPATH: gno.land/r/crossrealm_test | ||
| package crossrealm_test | ||
|
|
||
| import ( | ||
| "std" | ||
|
|
||
| crossrealm "gno.land/r/demo/tests/crossrealm/func" | ||
| ) | ||
|
|
||
| var b = 1 | ||
|
|
||
| type Local_S struct { | ||
| name string | ||
| } | ||
|
|
||
| func main() { | ||
| f := func() bool { | ||
| c := b | ||
| var ls *Local_S | ||
| return true | ||
| } | ||
| crossrealm.SetCallback(f) | ||
| println("ok") | ||
| } | ||
|
|
||
| // Output: | ||
| // ok |
There was a problem hiding this comment.
When a FuncValue is associated with an ownership tree, its parent block is persisted during finalization. The main reason for this is that when the FuncValue is executed, it needs to resolve names from its outer blocks.
However, this introduces a side effect: when a FuncValue is associated with an external realm, its "clo", the parent block(the main block in the code above) gets attached to that external realm, is it intended? if yes, while attaching this block to external realm, it is necessary to check recursively against the objects within this block , to identify if cross-realm happens, iff the block is un-real(if it's already real, everything is good), right?
So the FuncLit works similarly as MapLit, StructLit, etc.
↑ are some thoughts about FuncValue behavior in cross-realm situation after last call. @thehowl .
Anyway, will write some tests to explore this. And will appreciate if @jaekwon can help clarify this.
There was a problem hiding this comment.
Upon further consideration, if a function(closure) does not reference or capture any variables from outer scopes, it can be considered pure. As a result, the Closure field of the FuncValue is nil. Therefore, when associating this func with the current or an external realm, there is no need to attach its parent block, so this issue is also resolved: #3693, correct?
github-actions
bot
added
the
📦 ⛰️ gno.land
WIP: adding filetest for inter-realm spec, NOT FINAL.
relate: #2743
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description