Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples/gnoland): fix gnoland/home realm, rename the blog #3177

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Nov 21, 2024

Description

Fixes a broken link on the home page and renames the gno.land blog.

Two options for the blog name:

  • gno.land's blog
  • The Gno Blog

Option 1 seems favorable.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@leohhhn leohhhn changed the title chore(examples/gnoland): fix hall of fame realm, rename the blog chore(examples/gnoland): fix gnoland/home realm, rename the blog Nov 21, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@leohhhn leohhhn requested a review from moul November 21, 2024 15:50
@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 21, 2024
@jefft0
Copy link
Contributor

jefft0 commented Nov 25, 2024

Hi @leohhhn . Do you want to fix the merge conflict in file examples/gno.land/r/gnoland/blog/gnoblog_test.gno ?

@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Nov 26, 2024
@jefft0
Copy link
Contributor

jefft0 commented Nov 26, 2024

Removed the review/triage-pending label because this PR was approved by core dev ltzmaxwell.

@leohhhn leohhhn merged commit 496bcba into gnolang:master Nov 26, 2024
98 checks passed
@leohhhn leohhhn deleted the chore-minor-fixups branch November 26, 2024 10:58
r3v4s pushed a commit to gnoswap-labs/gno that referenced this pull request Dec 10, 2024
…lang#3177)

<!-- please provide a detailed description of the changes made in this
pull request. -->

## Description

Fixes a broken link on the home page and renames the gno.land blog. 

Two options for the blog name:
- gno.land's blog
- The Gno Blog

Option 1 seems favorable.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
</details>
albttx pushed a commit that referenced this pull request Jan 10, 2025
<!-- please provide a detailed description of the changes made in this
pull request. -->

## Description

Fixes a broken link on the home page and renames the gno.land blog. 

Two options for the blog name:
- gno.land's blog
- The Gno Blog

Option 1 seems favorable.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants